Fixing an anti-pattern in code and using guard clauses instead.
This commit is contained in:
parent
7725213f7a
commit
d8f4888aa7
@ -67,20 +67,16 @@ TiddlyWiki >> local: aFileRefence [
|
||||
|
||||
{ #category : 'accessing' }
|
||||
TiddlyWiki >> name [
|
||||
|
||||
^ name ifNil: [
|
||||
self file
|
||||
ifNil: [ | tempName suffix |
|
||||
tempName := self remote file.
|
||||
(tempName endsWithAnyOf: #('.html' '.htm'))
|
||||
ifTrue: [
|
||||
suffix := (tempName splitOn: '.') last.
|
||||
tempName := tempName removeSuffix: '.', suffix.
|
||||
].
|
||||
name := tempName
|
||||
]
|
||||
ifNotNil: [ name := self file basenameWithoutExtension ]
|
||||
]
|
||||
| tempName suffix |
|
||||
name ifNotNil: [ ^ name ].
|
||||
self file ifNotNil: [ ^ name := self file basenameWithoutExtension ].
|
||||
self remote ifNil: [ ^ name := nil ].
|
||||
tempName := self remote file.
|
||||
(tempName endsWithAnyOf: #('.html' '.htm')) ifTrue: [
|
||||
suffix := (tempName splitOn: '.') last.
|
||||
tempName := tempName removeSuffix: '.', suffix.
|
||||
].
|
||||
name := tempName
|
||||
]
|
||||
|
||||
{ #category : 'accessing' }
|
||||
|
Loading…
Reference in New Issue
Block a user