Offray
/
TiddlyWikiPharo
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing an anti-pattern in code and using guard clauses instead.

This commit is contained in:
Offray Vladimir Luna Cárdenas 2021-09-14 20:14:20 -05:00
parent 7725213f7a
commit d8f4888aa7
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
repository/TiddlyWiki/TiddlyWiki.class.st
View File

@ -67,20 +67,16 @@ TiddlyWiki >> local: aFileRefence [
{ #category : 'accessing' }
TiddlyWiki >> name [
^ name ifNil: [
self file
ifNil: [ | tempName suffix |
tempName := self remote file.
(tempName endsWithAnyOf: #('.html' '.htm'))
ifTrue: [
suffix := (tempName splitOn: '.') last.
tempName := tempName removeSuffix: '.', suffix.
].
name := tempName
]
ifNotNil: [ name := self file basenameWithoutExtension ]
]
| tempName suffix |
name ifNotNil: [ ^ name ].
self file ifNotNil: [ ^ name := self file basenameWithoutExtension ].
self remote ifNil: [ ^ name := nil ].
tempName := self remote file.
(tempName endsWithAnyOf: #('.html' '.htm')) ifTrue: [
suffix := (tempName splitOn: '.') last.
tempName := tempName removeSuffix: '.', suffix.
].
name := tempName
]
{ #category : 'accessing' }