Code review: Modularization.
This commit is contained in:
parent
65c36e924c
commit
bc168c4f0a
@ -1,4 +1,4 @@
|
|||||||
accessing
|
accessing
|
||||||
getMessages
|
getMessages
|
||||||
self getLocalMessages ifNil: [ self getRemoteMessages ].
|
self getLocalMessages ifNil: [ self getRemoteMessagesFromRss ].
|
||||||
^ self tweets
|
^ self tweets
|
@ -1,5 +1,5 @@
|
|||||||
accessing
|
accessing
|
||||||
getRemoteMessages
|
getRemoteMessagesFromRss
|
||||||
|
|
||||||
| customQuery lastTweetsRaw lastTweets |
|
| customQuery lastTweetsRaw lastTweets |
|
||||||
lastTweetsRaw := self rssFeed xmlDocument xpath: '//item'.
|
lastTweetsRaw := self rssFeed xmlDocument xpath: '//item'.
|
@ -0,0 +1,5 @@
|
|||||||
|
accessing
|
||||||
|
lastTweetsFromHtml
|
||||||
|
|
||||||
|
^ (self documentTree xpath: '//div[@class="timeline-item "]')
|
||||||
|
asOrderedCollection collect: [ :xmlElement | xmlElement postCopy ]
|
@ -5,31 +5,33 @@ numberOfURLsForLoadingTweets: number
|
|||||||
number = 1 ifTrue: [ ^ self ].
|
number = 1 ifTrue: [ ^ self ].
|
||||||
|
|
||||||
urlAndTweets := OrderedDictionary new.
|
urlAndTweets := OrderedDictionary new.
|
||||||
collectionURLs := { self userNameLink .}asOrderedCollection.
|
collectionURLs := { self userNameLink } asOrderedCollection.
|
||||||
|
|
||||||
urlAndTweets
|
urlAndTweets at: 'tweets' put: self lastTweetsFromHtml.
|
||||||
at: 'tweets'
|
|
||||||
put: ((self documentTree xpath: '//div[@class="timeline-item "]')asOrderedCollection collect: [ :xmlElement | xmlElement postCopy]).
|
|
||||||
|
|
||||||
count := 1.
|
count := 1.
|
||||||
(number-count) timesRepeat: [ | tempDoc docTree urlString |
|
number - count timesRepeat: [
|
||||||
|
| tempDoc docTree urlString |
|
||||||
tempDoc := XMLHTMLParser parse:
|
tempDoc := XMLHTMLParser parse:
|
||||||
(collectionURLs at: count) asUrl retrieveContents.
|
(collectionURLs at: count) asUrl retrieveContents.
|
||||||
|
|
||||||
urlString := (self userNameLink,
|
urlString := self userNameLink
|
||||||
((tempDoc xPath: '//a[.="Load more"]') @ 'href') stringValue).
|
,
|
||||||
|
((tempDoc xPath: '//a[.="Load more"]') @ 'href')
|
||||||
|
stringValue.
|
||||||
docTree := XMLHTMLParser parse: urlString asUrl retrieveContents.
|
docTree := XMLHTMLParser parse: urlString asUrl retrieveContents.
|
||||||
collectionURLs
|
collectionURLs add: urlString.
|
||||||
add: urlString.
|
|
||||||
|
|
||||||
urlAndTweets
|
urlAndTweets
|
||||||
at: 'tweets-' , (urlString splitOn: 'cursor=') second
|
at: 'tweets-' , (urlString splitOn: 'cursor=') second
|
||||||
put: ((docTree xpath: '//div[@class="timeline-item "]')asOrderedCollection
|
put:
|
||||||
collect: [ :xmlElement | xmlElement postCopy ]).
|
((docTree xpath: '//div[@class="timeline-item "]')
|
||||||
|
asOrderedCollection collect: [ :xmlElement |
|
||||||
|
xmlElement postCopy ]).
|
||||||
count := count + 1 ].
|
count := count + 1 ].
|
||||||
|
|
||||||
asURLs := collectionURLs collect: [ :string | string asUrl ].
|
asURLs := collectionURLs collect: [ :string | string asUrl ].
|
||||||
|
|
||||||
urlAndTweets at: 'urls' put: asURLs.
|
urlAndTweets at: 'urls' put: asURLs.
|
||||||
|
|
||||||
^ urlAndTweets.
|
^ urlAndTweets
|
Loading…
Reference in New Issue
Block a user