From 7bab421f802e3cbc1e097721e949c563187cfb52 Mon Sep 17 00:00:00 2001 From: Offray Luna Date: Wed, 6 Apr 2022 13:09:38 -0500 Subject: [PATCH] Code review: Fixing some code smells. --- .../NitterUser.class/instance/config.st | 2 +- .../NitterUser.class/instance/folder.st | 4 +++- .../NitterUser.class/instance/writeWordsFile.st | 9 +++------ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/Socialmetrica.package/NitterUser.class/instance/config.st b/Socialmetrica.package/NitterUser.class/instance/config.st index 68e5e4a..6c88c57 100644 --- a/Socialmetrica.package/NitterUser.class/instance/config.st +++ b/Socialmetrica.package/NitterUser.class/instance/config.st @@ -1,4 +1,4 @@ accessing config - ^ config \ No newline at end of file + ^ config ifNil: [ config := Dictionary new ] \ No newline at end of file diff --git a/Socialmetrica.package/NitterUser.class/instance/folder.st b/Socialmetrica.package/NitterUser.class/instance/folder.st index 140885f..e9cb231 100644 --- a/Socialmetrica.package/NitterUser.class/instance/folder.st +++ b/Socialmetrica.package/NitterUser.class/instance/folder.st @@ -1,4 +1,6 @@ accessing folder - ^ self config at: 'folder'. \ No newline at end of file + ^ self config + at: 'folder' + ifAbsentPut: [ FileLocator userData / 'Socialmetrica' / 'web' / 'twitter.com' / self userName ]. \ No newline at end of file diff --git a/Socialmetrica.package/NitterUser.class/instance/writeWordsFile.st b/Socialmetrica.package/NitterUser.class/instance/writeWordsFile.st index 7b32d4e..c8bf97c 100644 --- a/Socialmetrica.package/NitterUser.class/instance/writeWordsFile.st +++ b/Socialmetrica.package/NitterUser.class/instance/writeWordsFile.st @@ -7,13 +7,10 @@ writeWordsFile rawWords := OrderedCollection new. collectionsWords := ((rawTweets select: - [ :tweet | tweet user userName = 'FranciaMarquezM' ]) + [ :tweet | tweet user userName = self userName ]) collect: [ :tweet | (tweet words reject: [ :w | w includesSubstring: 'nitter42lfr' ]) ]). - count := 1. - collectionsWords size timesRepeat: [ - rawWords addAll: (collectionsWords at:count). - count := count + 1.]. + collectionsWords do: [ :word | rawWords addAll: word ]. rawWords := ' ' join:rawWords. - ^ MarkupFile exportAsFileOn: (FileLocator userData / 'Socialmetrica' / self userName / self userName, 'words', 'txt') containing: rawWords. \ No newline at end of file + ^ MarkupFile exportAsFileOn: (self folder / 'words', 'txt') containing: rawWords. \ No newline at end of file