From 2c61055b3850a6e0f8b75770815612d015c3d7da Mon Sep 17 00:00:00 2001 From: Offray Luna Date: Tue, 12 Apr 2022 12:03:48 -0500 Subject: [PATCH] Improved naming to better convey intention and more TO DO's. --- .../instance/collectRawTweetsForPages..st | 2 +- .../{pageURLs..st => getPagesContentsUntil..st} | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) rename Socialmetrica.package/NitterUser.class/instance/{pageURLs..st => getPagesContentsUntil..st} (50%) diff --git a/Socialmetrica.package/NitterUser.class/instance/collectRawTweetsForPages..st b/Socialmetrica.package/NitterUser.class/instance/collectRawTweetsForPages..st index ce5dbac..6296c51 100644 --- a/Socialmetrica.package/NitterUser.class/instance/collectRawTweetsForPages..st +++ b/Socialmetrica.package/NitterUser.class/instance/collectRawTweetsForPages..st @@ -2,7 +2,7 @@ accessing collectRawTweetsForPages: anInteger | pagesDict response | - pagesDict := self pageURLs: anInteger. + pagesDict := self getPagesContentsUntil: anInteger. response := TweetsCollection new. response query: pagesDict keys. pagesDict keysAndValuesDo: [ :key :rawTweets | | temp | diff --git a/Socialmetrica.package/NitterUser.class/instance/pageURLs..st b/Socialmetrica.package/NitterUser.class/instance/getPagesContentsUntil..st similarity index 50% rename from Socialmetrica.package/NitterUser.class/instance/pageURLs..st rename to Socialmetrica.package/NitterUser.class/instance/getPagesContentsUntil..st index 462dc38..398ee40 100644 --- a/Socialmetrica.package/NitterUser.class/instance/pageURLs..st +++ b/Socialmetrica.package/NitterUser.class/instance/getPagesContentsUntil..st @@ -1,7 +1,11 @@ accessing -pageURLs: anInteger - - | response nextPageLink previousPageLink dicTemp | +getPagesContentsUntil: anInteger + "I retroactively get all pages contents until a specified page number. + + TO DO: should this be splitted back to two methods, one getting the page urls and other its content? + or do we always be getting the cursor urls and its contents all the time. + [ ] Benchmark alternative approaches." + | response nextPageLink previousPageLink | response := OrderedDictionary new. response at: self userNameLink put: self documentTree.