Improving and cleaning: classes should take care of initializing simple objects collection of instances without creating new objects for that exclusive taks.

RoloLudo.package/SfAsset.class/README.md

@@ -2,5 +2,9 @@ I model an asset of the Ironsworn Starforged Tabletop Roleplaying Game.
 
 More information at: 
 
-[1] https://www.ironswornrpg.com/
+[1] <https://www.ironswornrpg.com/>
-[2] https://www.kickstarter.com/projects/shawntomkin/ironsworn-starforged
+[2] <https://www.kickstarter.com/projects/shawntomkin/ironsworn-starforged>
+
+I use as inspiration the data provided by @rsek at this repostory:
+
+<https://github.com/rsek/datasworn>

RoloLudo.package/SfAsset.class/class/collectionFromRepository.language..st

@@ -0,0 +1,6 @@
+accessing
+collectionFromRepository: jsonFileUrl language: isoCode
+| rawData |
+rawData := STON fromString: jsonFileUrl asUrl retrieveContents.
+^ (rawData at: 'Assets') collect: [:assetDict | 
+	self new fromDictionary: assetDict; language: isoCode ]

RoloLudo.package/SfAsset.class/class/collectionFromRepostory.st

@@ -0,0 +1,3 @@
+accessing
+collectionFromRepostory
+ ^ self collectionFromRepository: 'https://raw.githubusercontent.com/rsek/dataforged/main/assets.json' language: 'en'

RoloLudo.package/SfAsset.class/instance/fromDictionary..st

@@ -1,6 +1,6 @@
 accessing
 fromDictionary: aDictionary
 	name := aDictionary at: #Name.
-	category := aDictionary at: #Category.
+	category := aDictionary at: 'Asset Type'.
 	abilities := self populateAbilities: (aDictionary at: #Abilities)
 	

RoloLudo.package/SfAssets.class/README.md

@@ -1,4 +0,0 @@
-I model a collection of Starforged assets.
-I use as inspiration the data provided by @rsek at this repostory:
-
-https://github.com/rsek/datasworn

RoloLudo.package/SfAssets.class/instance/fromUrl..st

@@ -1,4 +0,0 @@
-instance creation
-fromUrl: aString
-	"Convinience shortcut as most of resources are published originally in English."
-	^ self fromUrl: aString language: 'en' 

RoloLudo.package/SfAssets.class/instance/fromUrl.language..st

@@ -1,8 +0,0 @@
-accessing
-fromUrl: aString language: isoCode
-
-| rawData |
-rawData := STON fromString: aString asUrl retrieveContents.
-self items: ((rawData at: 'Assets') collect: [:assetDict | 
-	SfAsset new fromDictionary: assetDict; language: isoCode ])
- 

RoloLudo.package/SfAssets.class/instance/items..st

@@ -1,3 +0,0 @@
-accessing
-items: anObject
-	items := anObject

RoloLudo.package/SfAssets.class/instance/items.st

@@ -1,3 +0,0 @@
-accessing
-items
-	^ items ifNil: [ items := OrderedCollection ]

RoloLudo.package/SfAssets.class/properties.json

@@ -1,13 +0,0 @@
-{
-	"commentStamp" : "GlamorousAuthor 5/17/2021 16:41",
-	"super" : "Object",
-	"category" : "RoloLudo",
-	"classinstvars" : [ ],
-	"pools" : [ ],
-	"classvars" : [ ],
-	"instvars" : [
-		"items"
-	],
-	"name" : "SfAssets",
-	"type" : "normal"
-}